On Mon, Jun 22, 2020 at 5:56 PM Denis Efremov <efre...@linux.com> wrote:
>
> clk_s is checked twice in a row in ni_init_smc_spll_table().
> fb_div should be checked instead.
>
> Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Denis Efremov <efre...@linux.com>Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/ni_dpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c > index b57c37ddd164..c7fbb7932f37 100644 > --- a/drivers/gpu/drm/radeon/ni_dpm.c > +++ b/drivers/gpu/drm/radeon/ni_dpm.c > @@ -2127,7 +2127,7 @@ static int ni_init_smc_spll_table(struct radeon_device > *rdev) > if (clk_s & ~(SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_MASK >> > SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_SHIFT)) > ret = -EINVAL; > > - if (clk_s & ~(SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_MASK >> > SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_SHIFT)) > + if (fb_div & ~(SMC_NISLANDS_SPLL_DIV_TABLE_FBDIV_MASK >> > SMC_NISLANDS_SPLL_DIV_TABLE_FBDIV_SHIFT)) > ret = -EINVAL; > > if (clk_v & ~(SMC_NISLANDS_SPLL_DIV_TABLE_CLKV_MASK >> > SMC_NISLANDS_SPLL_DIV_TABLE_CLKV_SHIFT)) > -- > 2.26.2 > > _______________________________________________ > amd-gfx mailing list > amd-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
