On Sun, Oct 21, 2007 at 11:33:05PM -0400, Michael Krufky wrote:
> Adrian Bunk wrote:
> > This patch fixes CONFIG_TUNER_TEA5761=m broken by
> > commit ca805d57cf5ea7482ed3da28653f30621249ee45.
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> >
> > ---
> >
> > drivers/media/video/tuner-core.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > 26336c30e76c37bda368a24b8b12978388a18cf3
> > diff --git a/drivers/media/video/tuner-core.c
> > b/drivers/media/video/tuner-core.c
> > index 9484308..1795b78 100644
> > --- a/drivers/media/video/tuner-core.c
> > +++ b/drivers/media/video/tuner-core.c
> > @@ -30,9 +30,7 @@
> >
> > /* standard i2c insmod options */
> > static unsigned short normal_i2c[] = {
> > -#ifdef CONFIG_TUNER_TEA5761
> > 0x10,
> > -#endif
> >
> ^^^ I believe that we want to keep these #ifdef's above... The removals
> below are fine.
>...
If it's required, then we need
#if defined(CONFIG_TUNER_TEA5761) || (defined(CONFIG_TUNER_TEA5761_MODULE) &&
defined(MODULE))
here for getting the modular case working.
But at least at first glance it seems the code already tries to handle
the cases when tea5761_{attach,autodetection}() fail?
> Regards,
>
> Mike Krufky
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
