It's a good practice to modify fields of a struct after but not before
it was initialised. Even though io_init_poll_iocb() doesn't touch
poll->file, call it first.

Signed-off-by: Pavel Begunkov <asml.sile...@gmail.com>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 84b39109bc30..676911260f60 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -4585,8 +4585,8 @@ static __poll_t __io_arm_poll_handler(struct io_kiocb 
*req,
        struct io_ring_ctx *ctx = req->ctx;
        bool cancel = false;
 
-       poll->file = req->file;
        io_init_poll_iocb(poll, mask, wake_func);
+       poll->file = req->file;
        poll->wait.private = req;
 
        ipt->pt._key = mask;
-- 
2.24.0

Reply via email to