On Thu, Oct 18, 2007 at 03:23:49PM -0400, Alan Stern wrote: > This patch (as1004) fixes a refcounting bug in the development version > of the block-device core. > > Signed-off-by: Alan Stern <[EMAIL PROTECTED]> > > --- > > Kay, you have got to start testing your patches better! Finding and > fixing refcount errors is _not_ one of my favorite ways to pass the > time. For example, you could see what happens when you insert and > unplug a USB flash disk a few times. > > Greg, you'll probably want to just fold this in with Kay's > block-device.patch. > > Alan Stern > > > Index: usb-2.6/fs/partitions/check.c > =================================================================== > --- usb-2.6.orig/fs/partitions/check.c > +++ usb-2.6/fs/partitions/check.c > @@ -516,5 +516,4 @@ void del_gendisk(struct gendisk *disk) > sysfs_remove_link(&block_depr, disk->dev.bus_id); > #endif > device_del(&disk->dev); > - put_device(&disk->dev); > }
Are we sure this is correct? Kay and I spent a lot of time (well, Kay did all the work) a few weeks ago trying to track down a bug in this area, and this was the solution from what I remember. Kay, thoughts? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
