On Mon, 15 Jun 2020 15:30:41 -0700
Randy Dunlap <rdun...@infradead.org> wrote:

> >> Please don't infect kernel sources with that style oddity.  
> > 
> > What do you mean? It's already "infected" all over the kernel, (has
> > been for years!) and I kinda like it. It makes reading variables much
> > easier on the eyes, and as I get older, that means a lot more ;-)  
> 
> Yeah, there is some infection, more in some places than others,
> but I agree with Joe -- it's not needed or wanted by some of us.

We all have preferences. But for code that I need to review, I prefer
it.

Why would you be bothered by it? Which is easier on the eyes to read
variables?

        struct xbc_node *leaf, *vnode;
        const char *val;
        char q;
        char *key, *end = dst + size;
        int ret = 0;

or

        struct xbc_node *leaf, *vnode;
        char *key, *end = dst + size;
        const char *val;
        char q;
        int ret = 0;

?

-- Steve

Reply via email to