On Wed, Oct 17, 2007 at 04:29:12PM +1000, Rusty Russell wrote: > On Wednesday 17 October 2007 15:37:54 Gautham R Shenoy wrote: > > On Wed, Oct 17, 2007 at 10:47:41AM +1000, Rusty Russell wrote: > > > On Tuesday 16 October 2007 20:34:17 Gautham R Shenoy wrote: > > > > This patch implements a Refcount + Waitqueue based model for > > > > cpu-hotplug. > > > > > > Hi Gautham, > > > > Hi Rusty, > > > > > I can't see where you re-initialize the completion. > > > > The cpu_hotplug.readers_done is a global variable which has been > > initialized in cpu_hotplug_init. > > > > So I am wondering is the re-initialization required ? > > Yes. AFAICT you use this completion on every hotplug. Yet once a completion > is completed, it needs to be re-initialized to be reused: it's "complete" and > wait_for_completion will return immediately thereafter. >
Okay, I thought completion followed the spinlock semantics, and hence didn't require re-initalization. Thanks for that information! > Perhaps you want a waitqueue instead? Yes, I had considered it. But completion looked appealing since it already had the wait-queuing code. I'll give it a try and repost the series with other changes. > > Rusty. Thanks and Regards gautham. -- Gautham R Shenoy Linux Technology Center IBM India. "Freedom comes with a price tag of responsibility, which is still a bargain, because Freedom is priceless!" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
