Hi! > > SysRq has already provided a similiar help before this patch, but it > > is not so clear that the user doesn't know what happened and what > > he/she should do. > > The person is in one of two states: > > 1) He has been told "recreate the problem, hit alt-sysreq-cokebottle, > and send me the results". He has a mission, and the only feedback he > needs is (a) that he hit cokebottle and not pepsibottle, and (b) the > resulting output. > > 2) He's already read the file in Documentation/ and just needs a reminder. > In this case, the fact it's only 2 or 3 lines and doesn't scroll other stuff > out of sight is more important. > > > In addition, that funtion has a big loop with another big loop > > embedded which is very inefficient, it is intended to skip some hot > > You're optimizing code that hopefully never gets executed, and even if > it does, you have the optimization *backwards*. If you're worried > about
Pretty much exact. Thanks for saying this so nicely. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/