Hi!
> > We don't really need if/else to set variable to 1/0.
> >
> > Signed-off-by: Pavel Machek (CIP) <pa...@denx.de>
> >
> > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> > index 12b98b466287..f9f6fd470c81 100644
> > --- a/drivers/usb/dwc2/gadget.c
> > +++ b/drivers/usb/dwc2/gadget.c
> > @@ -1761,10 +1761,7 @@ static int dwc2_hsotg_process_req_feature(struct
> > dwc2_hsotg *hsotg,
> > case USB_RECIP_DEVICE:
> > switch (wValue) {
> > case USB_DEVICE_REMOTE_WAKEUP:
> > - if (set)
> > - hsotg->remote_wakeup_allowed = 1;
> > - else
> > - hsotg->remote_wakeup_allowed = 0;
> > + hsotg->remote_wakeup_allowed = set;
> > break;
> >
> > case USB_DEVICE_TEST_MODE:
> >
>
> It's good catch, but 'set' declared as 'bool' while
> 'remote_wakeup_allowed' is 'unsigned int'. Maybe update 'set' type to same.
I know set is bool. But that should not matter, code is okay and
compiler will do the right thing:
pavel@amd:/tmp$ cat delme.c
#include <stdbool.h>
void main(void)
{
bool a = false;
int b = a;
}
pavel@amd:/tmp$ gcc -std=c99 -Wall delme.c
delme.c:3:6: warning: return type of ‘main’ is not ‘int’ [-Wmain]
void main(void)
^
delme.c: In function ‘main’:
delme.c:6:7: warning: unused variable ‘b’
[-Wunused-variable]
int b = a;
^
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
signature.asc
Description: Digital signature
