On Sun, May 31, 2020 at 02:56:41PM +0900, Namhyung Kim wrote: > On Thu, May 21, 2020 at 6:01 AM Arnaldo Carvalho de Melo > <[email protected]> wrote: > > > > Em Sun, May 10, 2020 at 11:06:15PM +0800, Changbin Du escreveu: > > > This adds an option '--nosleep-time' which allow us only to measure > > > on-CPU time. This option is function_graph tracer only. > > > > This seems, for now, very specific to the function_graph tracer, so > > perhaps we should have a: > > > > --function_graph_opts nosleep-time,other,another,etc > > > > ? > > Agreed. Also I don't want to add an option in a negative form > as it's confusing. Actually, our option parser can recognize > --no-xxx form automatically so adding a positive option (--xxx) > can handle that too. > Agree. And for the name, maybe we can align to original trace options.
root@WRT-WX9:/sys/kernel/debug/tracing# cat trace_options print-parent nosym-offset nosym-addr noverbose noraw nohex nobin noblock trace_printk annotate nouserstacktrace nosym-userobj noprintk-msg-only context-info nolatency-format record-cmd norecord-tgid overwrite nodisable_on_free irq-info markers noevent-fork function-trace nofunction-fork nodisplay-graph nostacktrace notest_nop_accept notest_nop_refuse > Thanks > Namhyung -- Cheers, Changbin Du
