Quoting Kees Cook (2020-06-03 16:31:59) > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just remove this variable since it was > actually unused: > > drivers/clk/st/clkgen-fsyn.c: In function \u2018quadfs_set_rate\u2019: > drivers/clk/st/clkgen-fsyn.c:793:6: warning: unused variable \u2018i\u2019 > [-Wunused-variable] > 793 | int i; > | ^ > > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-gli...@google.com/ > [2] > https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1tgqcr5vqkczwj0qxk6cernou6eedsuda...@mail.gmail.com/ > [3] > https://lore.kernel.org/lkml/ca+55afwgbgqhbp1fkxvrkepzyr5j8n1vkt1vzdz9knmpuxh...@mail.gmail.com/ > [4] > https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ > > Signed-off-by: Kees Cook <keesc...@chromium.org> > ---
Acked-by: Stephen Boyd <sb...@kernel.org>
