pon., 25 maj 2020 o 18:07 Michael Walle <mich...@walle.cc> napisał(a): > > This series is a split off of the sl28cpld series: > https://lore.kernel.org/linux-gpio/20200423174543.17161-1-mich...@walle.cc/ > > I wasn't sure if I should also include the gpiochip_irqchip_add_domain() > patch here. So feel free to skip it. OTOH if you use interrupts with > gpio-regmap it is quite handy. > > For an actual user see the patch 11/16 ("gpio: add support for the sl28cpld > GPIO controller") of the series above. > > Changes since v3: > - set reg_dat_base, that was actually broken > - fix typo > - fix swapped reg_in_dir/reg_out_dir documentation > - use "goto err" in error path in gpio_regmap_register() > > Changes since v2: > See changelog in the former patch series. > > Michael Walle (2): > gpiolib: Introduce gpiochip_irqchip_add_domain() > gpio: add a reusable generic gpio_chip using regmap > > drivers/gpio/Kconfig | 4 + > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-regmap.c | 343 ++++++++++++++++++++++++++++++++++++ > drivers/gpio/gpiolib.c | 20 +++ > include/linux/gpio-regmap.h | 69 ++++++++ > include/linux/gpio/driver.h | 3 + > 6 files changed, 440 insertions(+) > create mode 100644 drivers/gpio/gpio-regmap.c > create mode 100644 include/linux/gpio-regmap.h > > -- > 2.20.1 >
Both patches look good to me. I'd say we should apply them now and then fix any potential problems during the v5.8 release cycle. It's not like it's a user-space facing, stable interface, we don't have to be super careful when merging this kind of stuff. Bart
