From: Mike Rapoport <r...@linux.ibm.com>

commit c2bc26f7ca1ff1165bb6669a7a4cccc20ffd2ced upstream.

The kbuild test robot reported the following warning:

  arch/sparc/mm/srmmu.c: In function 'srmmu_nocache_init': 
arch/sparc/mm/srmmu.c:300:9: error: variable 'pud' set but not used 
[-Werror=unused-but-set-variable]
  300 |  pud_t *pud;

This warning is caused by misprint in the page table traversal in
srmmu_nocache_init() function which accessed a PMD entry using PGD
rather than PUD.

Since sparc32 has only 3 page table levels, the PGD and PUD are
essentially the same and usage of __nocache_fix() removed the type
checking.

Use PUD for the consistency and to silence the compiler warning.

Fixes: 7235db268a2777bc38 ("sparc32: use pgtable-nopud instead of 4level-fixup")
Reported-by: kbuild test robot <l...@intel.com>
Signed-off-by: Mike Rapoport <r...@linux.ibm.com>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
Cc: David S. Miller <da...@davemloft.net>
Cc: Anatoly Pugachev <mator...@gmail.com>
Cc: <sta...@vger.kernel.org>
Link: http://lkml.kernel.org/r/20200520132005.gm1059...@linux.ibm.com
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 arch/sparc/mm/srmmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -333,7 +333,7 @@ static void __init srmmu_nocache_init(vo
                pgd = pgd_offset_k(vaddr);
                p4d = p4d_offset(__nocache_fix(pgd), vaddr);
                pud = pud_offset(__nocache_fix(p4d), vaddr);
-               pmd = pmd_offset(__nocache_fix(pgd), vaddr);
+               pmd = pmd_offset(__nocache_fix(pud), vaddr);
                pte = pte_offset_kernel(__nocache_fix(pmd), vaddr);
 
                pteval = ((paddr >> 4) | SRMMU_ET_PTE | SRMMU_PRIV);


Reply via email to