On Thu, 11 Oct 2007, Andrew Morton wrote:
> And on s390
> In file included from arch/s390/kernel/binfmt_elf32.c:202:
> arch/s390/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_binary':
> arch/s390/kernel/../../../fs/binfmt_elf.c:1088: error: implicit declaration
> of function 'arch_randomize_brk'
This should be fixed trivially in the very same way as for x86_64, i.e.
something like
diff --git a/arch/s390/kernel/binfmt_elf32.c b/arch/s390/kernel/binfmt_elf32.c
index f1e40ca..4b5432d 100644
--- a/arch/s390/kernel/binfmt_elf32.c
+++ b/arch/s390/kernel/binfmt_elf32.c
@@ -199,5 +199,6 @@ cputime_to_compat_timeval(const cputime_t cputime, struct
compat_timeval *value)
value->tv_sec = cputime / 1000000;
}
+extern void arch_randomize_brk(void);
#include "../../../fs/binfmt_elf.c"
right? Maybe this would be needed for other architectures too :( I will
check this. I'd really like the patch go in, so that we have really full
randomization finally.
> I'll drop the patch. Really we should fix the elf mess before we try and
> change it any more.
I agree that it is a total mess. We'd need someone brave enough to rewrite
this crap :/
Thanks,
--
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
