On Thu, May 14, 2020 at 09:54:15AM +0300, Heikki Krogerus wrote: > On Wed, May 13, 2020 at 04:14:51PM -0700, Randy Dunlap wrote: > > On 5/13/20 2:30 PM, Brendan Higgins wrote: > > > On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus > > > <[email protected]> wrote: > > >> > > >> In the function kobject_cleanup(), kobject_del(kobj) is > > >> called before the kobj->release(). That makes it possible to > > >> release the parent of the kobject before the kobject itself. > > >> > > >> To fix that, adding function __kboject_del() that does > > >> everything that kobject_del() does except release the parent > > >> reference. kobject_cleanup() then calls __kobject_del() > > >> instead of kobject_del(), and separately decrements the > > >> reference count of the parent kobject after kobj->release() > > >> has been called. > > >> > > >> Reported-by: Naresh Kamboju <[email protected]> > > >> Reported-by: kernel test robot <[email protected]> > > >> Fixes: 7589238a8cf3 ("Revert "software node: Simplify > > >> software_node_release() function"") > > >> Cc: Brendan Higgins <[email protected]> > > >> Cc: Randy Dunlap <[email protected]> > > >> Suggested-by: "Rafael J. Wysocki" <[email protected]> > > >> Signed-off-by: Heikki Krogerus <[email protected]> > > > > > > Reviewed-by: Brendan Higgins <[email protected]> > > > Tested-by: Brendan Higgins <[email protected]> > > > > > > > Acked-by: Randy Dunlap <[email protected]> > > Tested-by: Randy Dunlap <[email protected]> > > Thanks guys. Sorry about the mix-up.
I didn't get the chance to review this today, will do so on Monday, thanks. greg k-h
