On 5/3/20 7:48 AM, Aishwarya Ramakrishnan wrote:
The function platform_get_irq can log an error by itself. This omit a redundant message for exception handling in the calling function.Suggested by Coccinelle. Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj...@gmail.com> --- drivers/i2c/busses/i2c-altera.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-altera.c b/drivers/i2c/busses/i2c-altera.c index f5c00f903df3..af6985f0ae63 100644 --- a/drivers/i2c/busses/i2c-altera.c +++ b/drivers/i2c/busses/i2c-altera.c @@ -395,10 +395,8 @@ static int altr_i2c_probe(struct platform_device *pdev) return PTR_ERR(idev->base);irq = platform_get_irq(pdev, 0);- if (irq < 0) { - dev_err(&pdev->dev, "missing interrupt resource\n"); + if (irq < 0) return irq; - }idev->i2c_clk = devm_clk_get(&pdev->dev, NULL);if (IS_ERR(idev->i2c_clk)) {
Reviewed-by: Thor Thayer <thor.tha...@linux.intel.com>
