Hi Krzysztof,

On 2020-04-28 3:26 a.m., Krzysztof Kozlowski wrote:
> On Sun, Apr 26, 2020 at 11:36:00AM -0700, Jonathan Bakker wrote:
>> The exynos-adc driver now supports the S5PV210, so add the DT
>> node so that devices can use it.
>>
>> Signed-off-by: Jonathan Bakker <xc-rac...@live.ca>
>> ---
>>  arch/arm/boot/dts/s5pv210.dtsi | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
>> index 2ad642f51fd9..b3b6ad2889f9 100644
>> --- a/arch/arm/boot/dts/s5pv210.dtsi
>> +++ b/arch/arm/boot/dts/s5pv210.dtsi
>> @@ -159,6 +159,18 @@
>>                      };
>>              };
>>  
>> +            adc: adc@126c0000 {
>> +                    compatible = "samsung,s5pv210-adc";
>> +                    reg = <0xe1700000 0x1000>;
> 
> reg does not match the node address.
> 
> Run "make dtbs W=1" and be sure there are no new warnings.

Thanks, will change for v2.

> 
> Best regards,
> Krzysztof
> 
> 
>> +                    interrupt-parent = <&vic2>;
>> +                    interrupts = <23>, <24>;
>> +                    clocks = <&clocks CLK_TSADC>;
>> +                    clock-names = "adc";
>> +                    #io-channel-cells = <1>;
>> +                    io-channel-ranges;
>> +                    status = "disabled";
>> +            };
>> +
>>              spi0: spi@e1300000 {
>>                      compatible = "samsung,s5pv210-spi";
>>                      reg = <0xe1300000 0x1000>;
>> -- 
>> 2.20.1
>>

Jonathan

Reply via email to