On Fri, Oct 18, 2019 at 6:41 AM Thomas Hellström (VMware) <[email protected]> wrote: > > From: Thomas Hellstrom <[email protected]> > > LLVM's assembler doesn't accept the short form INL instruction: > > inl (%%dx) > > but instead insists on the output register to be explicitly specified. > > This was previously fixed for the VMWARE_PORT macro. Fix it also for > the VMWARE_HYPERCALL macro. > > Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions") > Suggested-by: Sami Tolvanen <[email protected]> > Signed-off-by: Thomas Hellstrom <[email protected]>
Thank you for the patch. Reviewed-by: Nick Desaulniers <[email protected]> > Cc: [email protected] > Cc: "H. Peter Anvin" <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: x86-ml <[email protected]> > Cc: Borislav Petkov <[email protected]> > --- > arch/x86/include/asm/vmware.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h > index e00c9e875933..f5fbe3778aef 100644 > --- a/arch/x86/include/asm/vmware.h > +++ b/arch/x86/include/asm/vmware.h > @@ -29,7 +29,8 @@ > > /* The low bandwidth call. The low word of edx is presumed clear. */ > #define VMWARE_HYPERCALL \ > - ALTERNATIVE_2("movw $" VMWARE_HYPERVISOR_PORT ", %%dx; inl (%%dx)", \ > + ALTERNATIVE_2("movw $" VMWARE_HYPERVISOR_PORT \ > + ", %%dx; inl (%%dx), %%eax", \ > "vmcall", X86_FEATURE_VMCALL, \ > "vmmcall", X86_FEATURE_VMW_VMMCALL) > > -- > 2.21.0 > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20191018134052.3023-2-thomas_os%40shipmail.org. -- Thanks, ~Nick Desaulniers
