On Thu, Oct 17, 2019 at 03:00:22PM +0530, Viresh Kumar wrote: > On 17-10-19, 10:26, Sudeep Holla wrote: > > On Thu, Oct 17, 2019 at 08:09:36AM +0530, Viresh Kumar wrote: > > > On 16-10-19, 12:03, Sudeep Holla wrote: > > > > arm_big_little cpufreq driver was designed as a generic big little > > > > driver that could be used by any platform and make use of bL switcher. > > > > Over years alternate solutions have be designed and merged to deal with > > > > bL/HMP systems like EAS. > > > > > > > > Also since no other driver made use of generic arm_big_little cpufreq > > > > driver except Vexpress SPC, we can merge them together as vexpress-spc > > > > driver used only on Vexpress TC2(CA15_CA7) platform. > > > > > > > > Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com> > > > > --- > > > > MAINTAINERS | 5 +- > > > > drivers/cpufreq/Kconfig.arm | 12 +- > > > > drivers/cpufreq/Makefile | 2 - > > > > drivers/cpufreq/arm_big_little.c | 658 ------------------------ > > > > drivers/cpufreq/arm_big_little.h | 43 -- > > > > drivers/cpufreq/vexpress-spc-cpufreq.c | 661 ++++++++++++++++++++++++- > > > > 6 files changed, 652 insertions(+), 729 deletions(-) > > > > delete mode 100644 drivers/cpufreq/arm_big_little.c > > > > delete mode 100644 drivers/cpufreq/arm_big_little.h > > > > > > The delta produced here is enormous probably because you copy/pasted > > > things. I > > > am wondering if using git mv to rename arm_big_little.c and then move spc > > > bits > > > into it will make this delta smaller to review ? > > > > > > > Yes, I did a quick try but slightly different order. As I need the final > > driver to be vexpress-spc-cpufreq.c, I am thinking of first merging > > vexpress-spc-cpufreq.c into arm_big_little.c and then renaming it back > > later. Does that sound good ? > > Maybe git can produce short diff even if you do this in a single patch. But > two > would be fine if that makes me review lesss stuff :) >
You are right, I was so sure that -M is the option and got convinced that it's not working for this change, but what I needed was -B for format-patch. Thanks for reminding again and making me look harder ;) -- Regards, Sudeep
