On Thursday, 27 September 2007 17:49, Thomas Gleixner wrote: > On Thu, 2007-09-27 at 17:59 +0200, Rafael J. Wysocki wrote: > > > 2) CPU hotplug is busted (onlining of CPU1 kills the kernel), probably > > > due to > > > the same issue that I'm having with the -hrt version of 2.6.23-rc8 > > > (we're > > > debugging it right now) > > > > This one is fixed by the following patch: > > > > --- > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by a > > reference > > to disable_apic_timer (labeled as __initdata) from the CPU initialization > > code. > > > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Doh, I knew I blew it. > > Good catch, thanks,
Some good news from here. :-) WIth the patch below applied 2.6.23-rc8-mm2 works fine on the nx6325 _with_ NO_HZ and HIGH_RES_TIMERS set. Suspend and hibernation work as well, happy me. NO_HZ and HIGH_RES_TIMERS also work on this box with the hrt patch plus the C1E-related fix on top of 2.6.23-rc8. Does it make sense to test CPU_IDLE too at this point? Greetings, Rafael > > --- > > arch/x86_64/kernel/apic.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > > =================================================================== > > --- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c > > +++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c > > @@ -42,7 +42,7 @@ > > > > int apic_verbosity; > > static int apic_calibrate_pmtmr __initdata; > > -int disable_apic_timer __initdata; > > +int disable_apic_timer __cpuinitdata; > > > > /* Local APIC timer works in C2? */ > > int local_apic_timer_c2_ok; > > > -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
