On Fri, Sep 28, 2007 at 10:32:38AM +0200, Thomas Gleixner wrote: > On Fri, 2007-09-28 at 01:26 -0700, Andrew Morton wrote: > > On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <[EMAIL PROTECTED]> > > wrote: > > > > > can we please add this to checkpatch.pl ? > > > > > > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED; > > > > +DEFINE_SPINLOCK(bpci_lock); > > > > That check is already in checkpatch. Problem is that hardly anyone > > runs the thing. > > Sigh, I forgot that perl is write only. :) > > > I think we're ready to wire checkpatch up to a email robot which monitors > > the mailing lists and sends people nastygrams. I bet that'll be popular ;) > > We should wire it up to git-commit as well. A lot of that comes in via > git subsystems.
The problem with git-commit is who's repo to add the hook to. I did attempt to do this by picking up each of linus' main releases and then using the git blame engine to attribute each "failure" to a particular commit. The plan then would be to send a nasty-gram to the committer about violations there-in. I'll try and find some time to get this bit polished and at least emailing me. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
