On Thu, 2019-10-10 at 20:25 +0000, Robert Richter wrote: > Reduce the indentation level in edac_mc_handle_error() a bit by using > continue. No functional changes.
Seems fine, but trivially below: > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c [] > @@ -1171,37 +1171,38 @@ void edac_mc_handle_error(const enum > hw_event_mc_err_type type, [] > + strcpy(p, dimm->label); > + p += strlen(p); > + *p = '\0'; This *p = '\0' is unnecessary as the strcpy already did that.