The objdump command line is piped through grep and expand meaning
failures don't surface. Refactor symbol__disassemble so that it manages
the memory for the read line, as well as trimming and expanding tabs.
Correct the objdump flag '--no-show-raw' to be '--no-show-raw-insn'
which binutils objdump permissively allows but fails with LLVM objdump.

Ian Rogers (5):
  perf annotate: avoid reallocation in objdump parsing
  perf annotate: use run-command.h to fork objdump
  perf annotate: don't pipe objdump output through grep
  perf annotate: don't pipe objdump output through expand
  perf annotate: fix objdump --no-show-raw-insn flag

 tools/perf/util/annotate.c | 195 +++++++++++++++++++++++++------------
 1 file changed, 131 insertions(+), 64 deletions(-)

-- 
2.23.0.581.g78d2f28ef7-goog

Reply via email to