On Sat, Oct 5, 2019 at 6:36 PM Harald Arnesen <har...@skogtun.org> wrote:
>
> Harald Arnesen [05.10.2019 11:03]:
>
> > Masahiro Yamada [05.10.2019 05:24]:
> >
> >> I cannot reproduce it.
> >>
> >> I tested bindeb-pkg for the latest Linus tree successfully.
> >
> > Strange, I have now tried another machine running the same distro
> > (Devuan Beowulf), and I get the same result there. Will check further.
>
> I found out what was wrong.
>
> Both machines have been used for dvd burning, and I have used Jörg
> Schilling's cdrecord - and I had installed all of the "Schily Tools",
> which unfortunately includes a shell command. Now, I had (by mistake)
> /opt/schily/bin early in my path, and his OpenSolaris-derived shell
> didn't work as expected.
>
> Moving /opt/schily/bin to the end of the path fixes the problem.
>
> But shouldn't it work even if "sh" is not equal to "/bin/sh"?
CONFIG_SHELL previously fell back to 'sh' when bash is not installed,
so I just kept it as it was.
If we had used the exact absolute path /bin/sh,
it would have worked irrespective of the PATH environment.
But, there is a counter option like this:
commit 16f8259ca77d04f95e5ca90be1b1894ed45816c0
Author: Bjørn Forsman <bjorn.fors...@gmail.com>
Date: Sun Nov 5 10:44:16 2017 +0100
kbuild: /bin/pwd -> pwd
Most places use pwd and rely on $PATH lookup. Moving the remaining
absolute path /bin/pwd users over for consistency.
Also, a reason for doing /bin/pwd -> pwd instead of the other way around
is because I believe build systems should make little assumptions on
host filesystem layout. Case in point, we do this kind of patching
already in NixOS.
Ref. commit 028568d84da3cfca49f5f846eeeef01441d70451
("kbuild: revert $(realpath ...) to $(shell cd ... && /bin/pwd)").
Signed-off-by: Bjørn Forsman <bjorn.fors...@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
I cannot find a way to satisfy everybody.
--
Best Regards
Masahiro Yamada
