Re: [PATCH 5.2 123/313] ACPI / APEI: Release resources if gen_pool_add() fails

[Pavel Machek]

Hi!

> @@ -172,7 +173,19 @@ int ghes_estatus_pool_init(int num_ghes)
>        */
>       vmalloc_sync_all();
>  
> -     return gen_pool_add(ghes_estatus_pool, addr, PAGE_ALIGN(len), -1);
> +     rc = gen_pool_add(ghes_estatus_pool, addr, PAGE_ALIGN(len), -1);
> +     if (rc)
> +             goto err_pool_add;
> +
> +     return 0;
> +
> +err_pool_add:
> +     vfree((void *)addr);
> +

AFAICT this cast should not be neccessary.

Best regards,
                                                                        Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

signature.asc
Description: Digital signature