On mercoledì 26 settembre 2007, Thomas Gleixner wrote: > Jeff, > > On Tue, 2007-09-25 at 17:56 -0400, Jeff Dike wrote: > > On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: > > > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > > > > Put back an implementation of timeval_to_ns in > > > > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless > > > > support that there was a perfectly good implementation of it in > > > > linux/time.h. The problem is that this is userspace code which can't > > > > pull in kernel headers and there doesn't seem to be a libc version. > > > > > > Oops. Did not notice. > > > > It's a UML peculiarity... > > > > > Can't we move it into some header file which is accessible from > > > everywhere ? There is a way to do this without code duplication, but it is creating a non-inline function which calls the inline and calling the non-inline from userspace. It's done for a variety of other functions.
There is a tradeoff of speed vs code duplication - and if this function is not supposed to change and to need to be kept in sync, it could be copied. I conceptually hate this solution, but it can make some sense. -- "Doh!" (cit.), I've made another mistake! Paolo Giarrusso, aka Blaisorblade
signature.asc
Description: This is a digitally signed message part.
