can't we also decrease the number of brackets here? --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1021,7 +1021,7 @@ int ipv6_dev_get_saddr(struct net_device hiscore.rule++; } if (ipv6_saddr_preferred(score.addr_type) || - (((ifa_result->flags & + (((ifa->flags & (IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0))) {
make this like this if (ipv6_saddr_preferred(score.addr_type) || (ifa->flags & (IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0) { or even for clarity's sake: if (ipv6_saddr_preferred(score.addr_type) || (ifa->flags & (IFA_F_DEPRECATED|IFA_F_OPTIMISTIC)) == 0) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/