On Tue, Sep 10, 2019 at 11:31:21AM +0200, Lars Poeschel wrote: > It is favourable to have one unified compatible string for devices that > have multiple interfaces. So this adds simply "pn532" as the devicetree > binding compatible string and makes a note that the old ones are > deprecated.
Do you also need to update Documentation/devicetree/bindings/net/nfc/pn533-i2c.txt to both document the new compat string and deprecate the old ones? > Cc: Johan Hovold <jo...@kernel.org> > Signed-off-by: Lars Poeschel <poesc...@lemonage.de> > --- > Changes in v6: > - Rebased the patch series on v5.3-rc5 > > Changes in v3: > - This patch is new in v3 > > drivers/nfc/pn533/i2c.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c > index 1832cd921ea7..1abd40398a5a 100644 > --- a/drivers/nfc/pn533/i2c.c > +++ b/drivers/nfc/pn533/i2c.c > @@ -245,6 +245,11 @@ static int pn533_i2c_remove(struct i2c_client *client) > } > > static const struct of_device_id of_pn533_i2c_match[] = { > + { .compatible = "nxp,pn532", }, > + /* > + * NOTE: The use of the compatibles with the trailing "...-i2c" is > + * deprecated and will be removed. > + */ > { .compatible = "nxp,pn533-i2c", }, > { .compatible = "nxp,pn532-i2c", }, > {}, > -- > 2.23.0 >