On Sun, Sep 08, 2019 at 01:47:19AM +0300, Vitaly Gaiduk wrote:
> Hi, Andrew.<div>I’m ready to do this property with such name but is it good
> practice to do such long names? :)</div><div>Also, Trent Piepho wrote about
> sgmii-clk and merged all ideas we have “ti,sgmii-ref-clk”.</div><div>It’s
> better, isn’t it?</div><div>Vitaly.</div><div><div><br />07.09.2019, 18:39,
> "Andrew Lunn" <[email protected]>:<br /><blockquote><p>On Thu, Sep 05,
> 2019 at 07:26:00PM +0300, Vitaly Gaiduk wrote:<br /></p><blockquote
> class="b4fd5cf2ec92bc68cb898700bb81355fwmi-quote"> Add documentation of
> ti,sgmii-type which can be used to select<br /> SGMII mode type (4 or
> 6-wire).<br /><br /> Signed-off-by: Vitaly Gaiduk <<a
> href="mailto:[email protected]";>[email protected]</a>><br
> /> ---<br /> Documentation/devicetree/bindings/net/ti,dp83867.txt | 1 +<br
> /> 1 file changed, 1 insertion(+)<br /><br /> diff --git
> a/Documentation/devicetree/bindings/net/ti,dp83867.txt
> b/Documentation/devicetree/bindings/net/ti,dp83867.txt<br /> index
> db6aa3f2215b..18e7fd52897f 100644<br /> ---
> a/Documentation/devicetree/bindings/net/ti,dp83867.txt<br /> +++
> b/Documentation/devicetree/bindings/net/ti,dp83867.txt<br /> @@ -37,6 +37,7
> @@ Optional property:<br /> for applicable
> values. The CLK_OUT pin can also<br /> be
> disabled by this property. When omitted, the<br />
> PHY's default will be left as is.<br /> + - ti,sgmii-type - This
> denotes the fact which SGMII mode is used (4 or 6-wire).<br
> /></blockquote><p><br />Hi Vitaly<br /><br />You probably want to make this a
> Boolean. I don't think SGMII type is<br />a good idea. This is about enabling
> the receive clock to be passed to<br />the MAC. So how about
> ti,sgmii-ref-clock-output-enable.<br /><br /> Andrew<br
> /></p></blockquote></div></div>
Hi Vitaly
Please reconfigure your mail client to not obfuscate with HTML.
The length should be O.K. For a PHY node, it should not be too deeply
indented, unless it happens to be part of an Ethernet switch.
Andrew
