On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote: > On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote: > > > > > > > On 7 Sep 2019, at 19:29, Greg KH <gre...@linuxfoundation.org> wrote: > > > > On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote: > > > > Dear Greg, > > > > I am pretty sure the issue was, that I did too many things at once. > > > > However, all the things I did are related to spaces / tabs, maybe that > > > > still works? > > > > > > <snip> > > > > > > For some reason you sent this only to me, which is a bit rude to > > > everyone else on the mailing list. I'll be glad to respond if you > > > resend it to everyone. > > > > I'm sorry, newbie here. I thought it'd be better to not annoy everyone with > > responses but learning things everyday I guess :) > > No problem, but you should also line-wrap your emails :) > > > I am pretty sure the issue with my patch was that there was too many > > changes, however all of them were spaces and tabs related, so I think this > > could be fine? > > As the bot said, break it out into "one patch per logical change", and > "fix all whitespace issues" is not "one logical change".
As long as git diff -w shows no difference and a compiled object comparison before and after the change shows no difference, I think it's fine. In fact, it avoid multiple commits where the only changes are whitespace.
