On 9/6/19 11:30 PM, George McCollister wrote: [...]
> --- /dev/null > +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c > @@ -0,0 +1,100 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Microchip KSZ9477 series register access through I2C > + * > + * Copyright (C) 2018-2019 Microchip Technology Inc. Doesn't the copyright need update ? > + */ > + > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/regmap.h> > +#include <linux/i2c.h> Please keep the headers sorted. > +#include "ksz_common.h" > + > +KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0); > + The rest looks good. [...] -- Best regards, Marek Vasut
