On Fri, Aug 30, 2019 at 4:15 PM Rasmus Villemoes <li...@rasmusvillemoes.dk> wrote: > > Currently, compiler_types.h #defines __inline as inline (and further > #defines inline to automatically attach some attributes), so this does > not change functionality. It serves as preparation for removing the > #define of __inline. > > (Note that if ZSTD_STATIC is expanded somewhere where compiler_types.h > has not yet been processed, both __inline and inline both refer to the > compiler keyword, so again this does not change anything.) > > Signed-off-by: Rasmus Villemoes <li...@rasmusvillemoes.dk> > --- > lib/zstd/mem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/zstd/mem.h b/lib/zstd/mem.h > index 3a0f34c8706c..739837a59ad6 100644 > --- a/lib/zstd/mem.h > +++ b/lib/zstd/mem.h > @@ -27,7 +27,7 @@ > /*-**************************************** > * Compiler specifics > ******************************************/ > -#define ZSTD_STATIC static __inline __attribute__((unused)) > +#define ZSTD_STATIC static inline __attribute__((unused))
While you're here, would you mind replacing `__attribute__((unused))` with `__unused`? I would consider "naked attributes" (haven't been feature tested in include/linux/compiler_attributes.h and are verbose) to be an antipattern. > > /*-************************************************************** > * Basic Types > -- > 2.20.1 > -- Thanks, ~Nick Desaulniers
