Hi Anand, On Mon, Sep 2, 2019 at 10:58 AM Anand Moon <linux.am...@gmail.com> wrote: > > As per schematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: > fixed regulator output which is supplied by P5V0. > > Cc: Martin Blumenstingl <martin.blumensti...@googlemail.com> > Cc: Jerome Brunet <jbru...@baylibre.com> > Cc: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Anand Moon <linux.am...@gmail.com> one comment below, but overall this looks good: Reviewed-by: Martin Blumenstingl <martin.blumensti...@googlemail.com>
[...] > + vddc_ddr: regulator-vddc-ddr { > + compatible = "regulator-fixed"; > + regulator-name = "DDR3_1V5"; I prefer if the node name matches the regulator name, so in this case I would write above: ddr3_1v5: regulator-ddr-1v5 { Martin