On Fri, Aug 30, 2019 at 8:14 AM Josh Poimboeuf <jpoim...@redhat.com> wrote: > > What about just adding a couple of WRITE_ONCE's to sas_ss_reset()? That > would probably be the least disruptive option.
I think that WRITE_ONCE() with a comment about why is a good idea. The reason I dislike WRITE_ONCE() in general is not because it's wrong, it's because people often use it mindlessly and the rationale for it isn't clear. But with a comment about why, that issue obviously goes away. Linus