The strlen && strprefixeq check in get_node_by_path is
excessive, since strlen is checked in strprefixeq macro
internally. Thus, 'strlen(child->name) == p-path'
conjunct duplicates after macro expansion and could
be removed.

Signed-off-by: Denis Efremov <efre...@linux.com>
---
 scripts/dtc/livetree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/dtc/livetree.c b/scripts/dtc/livetree.c
index 0c039993953a..032df5878ccc 100644
--- a/scripts/dtc/livetree.c
+++ b/scripts/dtc/livetree.c
@@ -526,8 +526,7 @@ struct node *get_node_by_path(struct node *tree, const char 
*path)
        p = strchr(path, '/');
 
        for_each_child(tree, child) {
-               if (p && (strlen(child->name) == p-path) &&
-                   strprefixeq(path, p - path, child->name))
+               if (p && strprefixeq(path, p - path, child->name))
                        return get_node_by_path(child, p+1);
                else if (!p && streq(path, child->name))
                        return child;
-- 
2.21.0

Reply via email to