Re: [PATCH 07/13] dt-bindings: interrupt-controller: Add Loongson-3 HTINTC

[Jiaxun Yang]

On 2019/8/27 下午8:49, Rob Herring wrote:
On Tue, Aug 27, 2019 at 3:59 AM Jiaxun Yang <jiaxun.y...@flygoat.com> wrote:
Document Loongson-3 HyperTransport Interrupt controller.

Signed-off-by: Jiaxun Yang <jiaxun.y...@flygoat.com>
---
  .../loongson,ls3-htintc.yaml                  | 53 +++++++++++++++++++
  1 file changed, 53 insertions(+)
  create mode 100644 
Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml

diff --git 
a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml
 
b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml
new file mode 100644
index 000000000000..c1bc0faca656
--- /dev/null
+++ 
b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-htintc.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: 
"http://devicetree.org/schemas/interrupt-controller/loongson,ls3-htintc.yaml#";
+$schema: "http://devicetree.org/meta-schemas/core.yaml#";
+
+title: Loongson-3 HyperTransport Interrupt Controller
+
+maintainers:
+  - Jiaxun Yang <jiaxun.y...@flygoat.com>
+
+description: |
+  This interrupt controller is found in the Loongson-3 family of chips to 
transfer
+  interrupts from PCH connected on HyperTransport bus.
+
+properties:
+  compatible:
+    items:
+      - enum:
+        - loongson,ls3-htintc
Can be simplified to:

compatible
   const: loongson,ls3-htintc

+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 4
Need to list out what each of the 4 are.

Hi Rob

These 4 interrupts a just delivered randomly, So it's hard to give out a 
name.

Should I add a description for this?

Thanks,

--

Jiaxun Yang