At Fri, 14 Sep 2007 18:48:05 +0100, Denys Vlasenko wrote: > > Hi Takashi, > > There is a lot of data structures in that code, > and most of them seems to be read-only. > > I added const modifiers to most of such places: > > text data bss dec hex filename > 106315 179564 36 285915 45cdb snd-hda-intel.o > 283051 2624 36 285711 45c0f snd-hda-intel_patched.o > > Patch is attached. > > It moves "static struct hda_codec_preset *hda_preset_tables[]" > from hda_patch.h to hda_codec.c, and then adds > #include "hda_patch.h" > in a few .c files so that definitions of e.g. > const struct hda_codec_preset snd_hda_preset_analog[] > are checked to match declarations in hda_patch.h > > The rest of the patch (bulk of it) adds "const" > in many places. > > Patch is compile tested. Please apply. > > Signed-off-by: Denys Vlasenko <[EMAIL PROTECTED]>
Sorry for the late reply. First, thanks for your patch. Although I have also a similar patch pending on my tree, but it wasn't applied, because I'd like to mark these functions/data rather as __devinit*. And, sadly, init and const don't like with each other. So, my plan is to apply __devinit but without const. But, please don't hurry up to mark everything init yet now. I've been working on the dynamic codec parser on user-space and this would involve with some functions that are now apparently init functions. Since this isn't a critical issue, let's postpone it as a post-2.6.24 stuff. thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
