On Wed, Aug 14, 2019 at 08:23:54AM +0200, Christophe Leroy wrote: > Le 14/08/2019 à 07:49, Christoph Hellwig a écrit : > > Somehow this series is missing a cover letter. > > > > While you are touching all this "fun" can you also look into killing > > __ioremap? It seems to be a weird non-standard version of ioremap_prot > > (probably predating ioremap_prot) that is missing a few lines of code > > setting attributes that might not even be applicable for the two drivers > > calling it. > > > > ocm_init_node() [arch/powerpc/platforms/4xx/ocm.c] calls __ioremap() with > _PAGE_EXEC set while ioremap_prot() clears _PAGE_EXEC
Indeed. But I don't see anything marking this intentional. Then again the driver is entirely unused, so we might as well kill it off now.
