On Tue, Aug 13, 2019 at 09:46:40PM +0800, Baolin Wang wrote: > Add Spreadtrum PWM controller documentation. > > Signed-off-by: Baolin Wang <[email protected]> > --- > Changes from v1: > - Use assigned-clock-parents and assigned-clocks to set PWM clock parent. > --- > Documentation/devicetree/bindings/pwm/pwm-sprd.txt | 38 > ++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sprd.txt > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sprd.txt > b/Documentation/devicetree/bindings/pwm/pwm-sprd.txt > new file mode 100644 > index 0000000..e6cf312 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-sprd.txt > @@ -0,0 +1,38 @@ > +Spreadtrum PWM controller > + > +Spreadtrum SoCs PWM controller provides 4 PWM channels. > + > +Required porperties:
s/porperties/properties/ > +- compatible : Should be "sprd,ums512-pwm". > +- reg: Physical base address and length of the controller's registers. > +- clocks: The phandle and specifier referencing the controller's clocks. > +- clock-names: Should contain following entries: > + "pwmn": used to derive the functional clock for PWM channel n (n range: 0 > ~ 3). > + "enablen": for PWM channel n enable clock (n range: 0 ~ 3). > +- assigned-clocks: Reference to the PWM clock entroes. s/entroes/entries/ > +- assigned-clock-parents: The phandle of the parent clock of PWM clock. I'm not sure you need to point out assigned-clocks and assigned-clock-parents as this is general clk stuff. Also I wonder if these should be "required properties". > +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description of > + the cells format. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
