Hi Stephen, On Sunday 16 September 2007 15:55, Stephen Hemminger wrote: > On Fri, 14 Sep 2007 01:30:58 -0400 > Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > Hi Stephen, > > > > On Wednesday 12 September 2007 07:38, Stephen Hemminger wrote: > > > This driver supports the application buttons on some Fujitsu Lifebook > > > laptops. > > > It is based on the earlier apanel driver done by Jochen Eisenger, but > > > with many changes. The original driver used ioctl's and a separate > > > user space program; see http://apanel.sourceforge.net/tech.php > > > This version hooks into the input subsystem so that the normal > > > Gnome/KDE shortcuts work without any userspace changes. > > > > > > The Mail Led is handled via leds class device. > > > > > > > Thank you very much for convering the led to led subsystem. I tried > > implementing loadable keymap support in the driver, could you please > > try the patch below and if it still works for you then I will apply > > it to my tree. > > > > Sorry, you are raising the bar for new drivers, higher than existing code. > It is really bad (second system syndrome), if maintainers keep wanting > new code to to more than existing drivers. > > Please take driver AS IS. Go ahead and add loadable key map support,
I think I did that. I just asked you to run another test to make sure I did not screw up. Please find the time to do that and the patch will be applied. Unfortunately I do not own the hardware in question to do such test myself. > but fix all the other drivers in the tree at the same time that use the > existing > interface. > I will, time permitting. The support for doing loadable keymaps for drivers with sparse scancodes (or their equivalent) was added not so long ago, that's why there are a few drivers that don't implement loadable keymaps. But still many others do. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
