From: Nathan Chancellor <natechancel...@gmail.com>
Date: Sun, 11 Aug 2019 20:13:45 -0700
> clang warns:
>
> drivers/net/ethernet/toshiba/tc35815.c:1507:30: warning: use of logical
> '&&' with constant operand [-Wconstant-logical-operand]
> if (!HAVE_DMA_RXALIGN(lp) && NET_IP_ALIGN)
> ^ ~~~~~~~~~~~~
> drivers/net/ethernet/toshiba/tc35815.c:1507:30: note: use '&' for a
> bitwise operation
> if (!HAVE_DMA_RXALIGN(lp) && NET_IP_ALIGN)
> ^~
> &
> drivers/net/ethernet/toshiba/tc35815.c:1507:30: note: remove constant to
> silence this warning
> if (!HAVE_DMA_RXALIGN(lp) && NET_IP_ALIGN)
> ~^~~~~~~~~~~~~~~
> 1 warning generated.
>
> Explicitly check that NET_IP_ALIGN is not zero, which matches how this
> is checked in other parts of the tree. Because NET_IP_ALIGN is a build
> time constant, this check will be constant folded away during
> optimization.
>
> Fixes: 82a9928db560 ("tc35815: Enable StripCRC feature")
> Link: https://github.com/ClangBuiltLinux/linux/issues/608
> Signed-off-by: Nathan Chancellor <natechancel...@gmail.com>
Applied but I think clang is being rediculous.
