On Sat, 2019-08-10 at 19:04 -0700, Nathan Chancellor wrote: > On a tangential note, how are you planning on doing the fallthrough > comment to attribute conversion? The reason I ask is clang does not > support the comment annotations, meaning that when Nathan Huckleberry's > patch is applied to clang (which has been accepted [1]), we are going > to get slammed by the warnings. I just ran an x86 defconfig build at > 296d05cb0d3c with his patch applied and I see 27673 instances of this > warning... (mostly coming from some header files so nothing crazy but it > will be super noisy). > > If you have something to share like a script or patch, I'd be happy to > test it locally. > > [1]: https://reviews.llvm.org/D64838
Something like this patch: https://lore.kernel.org/patchwork/patch/1108577/ Maybe use: #define fallthrough [[fallthrough]] if the compiler supports that notation
