On Tue, Aug 06, 2019 at 05:29:15PM -0700, Paul E. McKenney wrote:
> On Tue, Aug 06, 2019 at 05:20:41PM -0400, Joel Fernandes (Google) wrote:
> > This test runs kfree_rcu in a loop to measure performance of the new
> > kfree_rcu, with and without patch.
> >
> > To see improvement, run with boot parameters:
> > rcuperf.kfree_loops=2000 rcuperf.kfree_alloc_num=100 rcuperf.perf_type=kfree
> >
> > Without patch, test runs in 6.9 seconds.
> > With patch, test runs in 6.1 seconds (+13% improvement)
> >
> > If it is desired to run the test but with the traditional (non-batched)
> > kfree_rcu, for example to compare results, then you could pass along the
> > rcuperf.kfree_no_batch=1 boot parameter.
>
> You lost me on this one. You ran two runs, with rcuperf.kfree_no_batch=1
> and without? Or you ran this patch both with and without the earlier
> patch, and could have run with the patch and rcuperf.kfree_no_batch=1?
>
> If the latter, it would be good to try all three.
Did this in new patch, will post shortly.
[snip]
> > +torture_param(int, kfree_nthreads, -1, "Number of RCU reader threads");
> > +torture_param(int, kfree_alloc_num, 8000, "Number of allocations and frees
> > done by a thread");
> > +torture_param(int, kfree_alloc_size, 16, "Size of each allocation");
>
> Is this used? How does it relate to KFREE_OBJ_BYTES?
It is not used, I removed it.
> > +torture_param(int, kfree_loops, 10, "Size of each allocation");
>
> I suspect that this kfree_loops string is out of date.
Updated, thanks.
> > +torture_param(int, kfree_no_batch, 0, "Use the non-batching (slower)
> > version of kfree_rcu");
>
> All of these need to be added to kernel-parameters.txt. Along with
> any added by the earlier patch, for that matter.
Will do.
> > +static struct task_struct **kfree_reader_tasks;
> > +static int kfree_nrealthreads;
> > +static atomic_t n_kfree_perf_thread_started;
> > +static atomic_t n_kfree_perf_thread_ended;
> > +
> > +#define KFREE_OBJ_BYTES 8
> > +
> > +struct kfree_obj {
> > + char kfree_obj[KFREE_OBJ_BYTES];
> > + struct rcu_head rh;
> > +};
> > +
> > +void kfree_call_rcu_nobatch(struct rcu_head *head, rcu_callback_t func);
> > +
> > +static int
> > +kfree_perf_thread(void *arg)
> > +{
> > + int i, l = 0;
>
> It is really easy to confuse "l" and "1" in some fonts, so please use
> a different name. (From the "showing my age" department: On typical
> 1970s typewriters, there was no numeral "1" -- you typed the letter
> "l" instead, thus anticipating at least the first digit of "1337".)
Change l to loops ;). I did see typewriters around in my childhood, I thought
they were pretty odd machines :-D. I am sure my daughter will think the same
about land-line phones :-D
> > + long me = (long)arg;
> > + struct kfree_obj **alloc_ptrs;
> > + u64 start_time, end_time;
> > +
> > + VERBOSE_PERFOUT_STRING("kfree_perf_thread task started");
> > + set_cpus_allowed_ptr(current, cpumask_of(me % nr_cpu_ids));
> > + set_user_nice(current, MAX_NICE);
> > + atomic_inc(&n_kfree_perf_thread_started);
> > +
> > + alloc_ptrs = (struct kfree_obj **)kmalloc(sizeof(struct kfree_obj *) *
> > kfree_alloc_num,
> > + GFP_KERNEL);
> > + if (!alloc_ptrs)
> > + return -ENOMEM;
> > +
> > + start_time = ktime_get_mono_fast_ns();
>
> Don't you want to announce that you started here rather than above in
> order to avoid (admittedly slight) measurement inaccuracies?
Yes, in revised patch I am announcing here.
> > + do {
> > + for (i = 0; i < kfree_alloc_num; i++) {
> > + alloc_ptrs[i] = kmalloc(sizeof(struct kfree_obj),
> > GFP_KERNEL);
> > + if (!alloc_ptrs[i])
> > + return -ENOMEM;
> > + }
> > +
> > + for (i = 0; i < kfree_alloc_num; i++) {
> > + if (!kfree_no_batch) {
> > + kfree_rcu(alloc_ptrs[i], rh);
> > + } else {
> > + rcu_callback_t cb;
> > +
> > + cb = (rcu_callback_t)(unsigned
> > long)offsetof(struct kfree_obj, rh);
> > + kfree_call_rcu_nobatch(&(alloc_ptrs[i]->rh),
> > cb);
> > + }
> > + }
> > +
> > + schedule_timeout_uninterruptible(2);
>
> Why the two-jiffy wait in the middle of a timed test? Yes, you need
> a cond_resched() and maybe more here, but a two-jiffy wait? I don't
> see how this has any chance of getting valid measurements.
>
> What am I missing here?
Replace it with cond_resched() as we discussed.
> > + } while (!torture_must_stop() && ++l < kfree_loops);
> > +
> > + kfree(alloc_ptrs);
> > +
> > + if (atomic_inc_return(&n_kfree_perf_thread_ended) >=
> > kfree_nrealthreads) {
> > + end_time = ktime_get_mono_fast_ns();
>
> Don't we want to capture the end time before the kfree()?
Fixed.
> > + pr_alert("Total time taken by all kfree'ers: %llu ns, loops:
> > %d\n",
> > + (unsigned long long)(end_time - start_time),
> > kfree_loops);
> > + if (shutdown) {
> > + smp_mb(); /* Assign before wake. */
> > + wake_up(&shutdown_wq);
> > + }
> > + }
> > +
> > + torture_kthread_stopping("kfree_perf_thread");
> > + return 0;
> > +}
> > +
> > +static void
> > +kfree_perf_cleanup(void)
> > +{
> > + int i;
> > +
> > + if (torture_cleanup_begin())
> > + return;
> > +
> > + if (kfree_reader_tasks) {
> > + for (i = 0; i < kfree_nrealthreads; i++)
> > + torture_stop_kthread(kfree_perf_thread,
> > + kfree_reader_tasks[i]);
> > + kfree(kfree_reader_tasks);
> > + }
> > +
> > + torture_cleanup_end();
> > +}
> > +
> > +/*
> > + * shutdown kthread. Just waits to be awakened, then shuts down system.
> > + */
> > +static int
> > +kfree_perf_shutdown(void *arg)
> > +{
> > + do {
> > + wait_event(shutdown_wq,
> > + atomic_read(&n_kfree_perf_thread_ended) >=
> > + kfree_nrealthreads);
> > + } while (atomic_read(&n_kfree_perf_thread_ended) < kfree_nrealthreads);
> > +
> > + smp_mb(); /* Wake before output. */
> > +
> > + kfree_perf_cleanup();
> > + kernel_power_off();
> > + return -EINVAL;
> > +}
>
> Is there some way to avoid (almost) duplicating rcu_perf_shutdown()?
At the moment, I don't see a good way to do this without passing in function
pointers or using macros which I think would look uglier than the above
addition. Sorry.
thanks,
- Joel
