On Sat, Aug 10, 2019 at 03:38:08PM +0300, Oded Gabbay wrote: > Now that we don't print the queue testing messages, we need to print when > the reset is finished so whoever looks at the kernel log will know the > reset process was finished successfully and the driver is not stuck. > > Signed-off-by: Oded Gabbay <[email protected]> > --- > drivers/misc/habanalabs/device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/misc/habanalabs/device.c > b/drivers/misc/habanalabs/device.c > index 9a5926888b99..1fac808c2546 100644 > --- a/drivers/misc/habanalabs/device.c > +++ b/drivers/misc/habanalabs/device.c > @@ -907,6 +907,8 @@ int hl_device_reset(struct hl_device *hdev, bool > hard_reset, > else > hdev->soft_reset_cnt++; > > + dev_info(hdev->dev, "Successfully finished resetting the device\n");
Really? For doing things "properly" there is no need to spam the kernel log. Only spit stuff out if an error happens. thanks, greg k-h
