Re: [PATCH 1/2] PCI: pciehp: Do not disable interrupt twice on suspend

[Lukas Wunner]

On Tue, Jun 18, 2019 at 03:50:50PM +0300, Mika Westerberg wrote:
> @@ -313,10 +332,12 @@ static struct pcie_port_service_driver hpdriver_portdrv 
> = {
>       .remove         = pciehp_remove,
>  
>  #ifdef       CONFIG_PM
> +#ifdef       CONFIG_PM_SLEEP
>       .suspend        = pciehp_suspend,
>       .resume_noirq   = pciehp_resume_noirq,
> +#endif
>       .resume         = pciehp_resume,
> -     .runtime_suspend = pciehp_suspend,
> +     .runtime_suspend = pciehp_runtime_suspend,
>       .runtime_resume = pciehp_runtime_resume,
>  #endif       /* PM */
>  };

Hm, why isn't ".resume" part of the "#ifdef CONFIG_PM_SLEEP" section?

Otherwise LGTM.

Thanks,

Lukas