On Thu, Aug 1, 2019 at 2:45 AM Stephen Boyd <swb...@chromium.org> wrote: > > Quoting Stephen Boyd (2019-07-31 16:45:31) > > > > This approach also nicely detects duplicate wakeup source names in the > > case that the string passed in to wakeup_source_register() is already > > used on the virtual bus. > > This was clearly untested! Here's a better one. This is what I see on my > device with this patch squashed in: > > localhost ~ # cat /sys/kernel/debug/wakeup_sources > name active_count event_count wakeup_count expire_count > active_since total_time max_time last_change > prevent_suspend_time > 1-1.2.4.1 0 0 0 0 > 0 0 0 0 0 > 1-1.1 0 0 0 0 > 0 0 0 0 0 > gpio-keys 0 0 0 0 > 0 0 0 0 0 > spi10.0 0 0 0 0 > 0 0 0 0 0 > a88000.spi:ec@0:keyboard-controller 0 0 0 > 0 0 0 0 > 0 0 > alarmtimer 0 0 0 0 > 0 0 0 0 0 > cros-ec-rtc.1.auto 0 0 0 0 > 0 0 0 0 > 0 > a8f8800.usb 0 0 0 0 > 0 0 0 0 0 > a6f8800.usb 0 0 0 0 > 0 0 0 0 0 > localhost ~ # ls -l /sys/class/wakeup/ > total 0 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 alarmtimer -> > ../../devices/platform/soc/ac0000.geniqup/a88000.spi/spi_master/spi10/spi10.0/cros-ec-dev.0.auto/cros-ec-rtc.1.auto/rtc/rtc0/alarmtimer
So why is this not "(...)rtc0/wakeup/alarmtimer" ? This particular bit looks kind of inconsistent. I guess without your patch you'd see "(...)rtc0/wakeup/wakeup0" instead, right? > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup0 -> > ../../devices/platform/soc/a6f8800.usb/wakeup/wakeup0 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup1 -> > ../../devices/platform/soc/a8f8800.usb/wakeup/wakeup1 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup2 -> > ../../devices/platform/soc/ac0000.geniqup/a88000.spi/spi_master/spi10/spi10.0/cros-ec-dev.0.auto/cros-ec-rtc.1.auto/wakeup/wakeup2 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup3 -> > ../../devices/platform/soc/ac0000.geniqup/a88000.spi/spi_master/spi10/spi10.0/a88000.spi:ec@0:keyboard-controller/wakeup/wakeup3 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup4 -> > ../../devices/platform/soc/ac0000.geniqup/a88000.spi/spi_master/spi10/spi10.0/wakeup/wakeup4 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup5 -> > ../../devices/platform/gpio-keys/wakeup/wakeup5 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup6 -> > ../../devices/platform/soc/a8f8800.usb/a800000.dwc3/xhci-hcd.7.auto/usb1/1-1/1-1.1/wakeup/wakeup6 > lrwxrwxrwx. 1 root root 0 Jul 31 17:43 wakeup7 -> > ../../devices/platform/soc/a8f8800.usb/a800000.dwc3/xhci-hcd.7.auto/usb1/1-1/1-1.2/1-1.2.4/1-1.2.4.1/wakeup/wakeup7 >
