On Fri, Jul 26, 2019 at 2:41 AM Christian Brauner <christ...@brauner.io> wrote:
>
> - if (type < PIDTYPE_MAX)
> + if (type < PIDTYPE_MAX && !pid)
> pid = find_get_pid(upid);
So now we have four cases in the switch statement, and two of them do
*not* want that "find_get_pid()" call.
Honestly, let's just move that whole thing into the switch statement
for the two cases that do want it. Particulartly since I think the
"upid == 0" case for P_PGID will prefer it that way anyway.
Let's not check 'type' in two different places in two completely
different ways.
Ok?
Linus
