It seems from the very beginning the error check has been missed
in axp288_extcon_log_rsi(). Add it here.

Cc: Ramakrishna Pallala <ramakrishna.pall...@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
- added error message (Chanwoo)
 drivers/extcon/extcon-axp288.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 7254852e6ec0..694a8d4a57ff 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -135,6 +135,11 @@ static void axp288_extcon_log_rsi(struct 
axp288_extcon_info *info)
        int ret;
 
        ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
+       if (ret < 0) {
+               dev_err(info->dev, "failed to read reset source indicator\n");
+               return;
+       }
+
        for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
                if (val & BIT(i)) {
                        dev_dbg(info->dev, "%s\n", *rsi);
-- 
2.20.1

Reply via email to