Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.

Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
---

Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.

 drivers/mfd/max8925-i2c.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
index 20bb19b71109..114e905bef25 100644
--- a/drivers/mfd/max8925-i2c.c
+++ b/drivers/mfd/max8925-i2c.c
@@ -176,18 +176,18 @@ static int max8925_probe(struct i2c_client *client,
        dev_set_drvdata(chip->dev, chip);
        mutex_init(&chip->io_lock);
 
-       chip->rtc = i2c_new_dummy(chip->i2c->adapter, RTC_I2C_ADDR);
-       if (!chip->rtc) {
+       chip->rtc = i2c_new_dummy_device(chip->i2c->adapter, RTC_I2C_ADDR);
+       if (IS_ERR(chip->rtc)) {
                dev_err(chip->dev, "Failed to allocate I2C device for RTC\n");
-               return -ENODEV;
+               return PTR_ERR(chip->rtc);
        }
        i2c_set_clientdata(chip->rtc, chip);
 
-       chip->adc = i2c_new_dummy(chip->i2c->adapter, ADC_I2C_ADDR);
-       if (!chip->adc) {
+       chip->adc = i2c_new_dummy_device(chip->i2c->adapter, ADC_I2C_ADDR);
+       if (IS_ERR(chip->adc)) {
                dev_err(chip->dev, "Failed to allocate I2C device for ADC\n");
                i2c_unregister_device(chip->rtc);
-               return -ENODEV;
+               return PTR_ERR(chip->adc);
        }
        i2c_set_clientdata(chip->adc, chip);
 
-- 
2.20.1

Reply via email to