On Sun, 9 Sep 2007 18:01:26 +0100 "Adrian McMenamin" <[EMAIL PROTECTED]> wrote:
> This patch adds support for the SEGA Dreamcast keyboard. > > Following suggestions from the inout maintainer it has been somewhat > rewritten since the previous posting > (http://lkml.org/lkml/2007/9/4/168). Hi, this driver in general is quite clean as well; I have only one suggestion for improvement. Right now you use a semaphore for locking, while all you really use it for is mutex semantics, I think it would be a good idea to convert the driver to use the actual mutex primitive; this will buy you a lot of extra automatic checking for bugs... Greetings, Arjan van de Ven - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
