On 15-Jul 18:42, Michal Koutný wrote: > On Mon, Jul 08, 2019 at 09:43:55AM +0100, Patrick Bellasi > <patrick.bell...@arm.com> wrote: > > +static void uclamp_update_root_tg(void) > > +{ > > + struct task_group *tg = &root_task_group; > > + > > + uclamp_se_set(&tg->uclamp_req[UCLAMP_MIN], > > + sysctl_sched_uclamp_util_min, false); > > + uclamp_se_set(&tg->uclamp_req[UCLAMP_MAX], > > + sysctl_sched_uclamp_util_max, false); > > + > > + cpu_util_update_eff(&root_task_group.css); > > +} > cpu_util_update_eff internally calls css_for_each_descendant_pre() so > this should be protected with rcu_read_lock().
Right, good catch! Will add in v12. Cheers, Patrick -- #include <best/regards.h> Patrick Bellasi